Update Gitpod live demo setup steps to README #367
Conversation
IbrahimFradj
requested review from
ebugden,
PatrickTasse,
MatthewKhouzam and
bhufmann
There was a problem hiding this comment.
This is great! ☀️
- I enjoy that the gif of the process feels like a real person is completing the tasks (compared to impeccable lightning speed execution). It's reassuring for users.
- I like the yellow highlight that appears behind the cursor when you click. It's useful extra info.
|
@IbrahimFradj Can you switch the paths to what they should be when merged so that it's ready to go? |
IbrahimFradj
force-pushed
the
IF-gitpodDemo
branch
2 times, most recently
from
863a1f8 to
93b5b5c
Compare
|
@ebugden i changed the paths to what they should be when merged |
There was a problem hiding this comment.
@MatthewKhouzam When this is merged will the old files automatically be overwritten? The new images have identical file names to the old ones.
@ebugden @MatthewKhouzam @IbrahimFradj new versions of screenshots with the same file name used to be not updated on github pages. They are somehow cached on GitHub.. I did some research on the web and many people where complaining about that. Unfortunately I can't find any link at the moment for that. To avoid this issue, all the images that I've uploaded in doc/images directory have a number as suffix. When there is a new version I upload a new file with a new number, delete the old one and reference the new file in the readme. I don't know if this is still an issue, but my approach for sure works. |
Oh fun, thanks for the heads up! So @IbrahimFradj
Just checked the readme on Ibrahim's branch for this PR and it shows the old images so this is still an issue: |
IbrahimFradj
force-pushed
the
IF-gitpodDemo
branch
2 times, most recently
from
2349355 to
762bfca
Compare
|
@ebugden i changed the paths and the name of the media files. we can see the result in readme on the branch. |
There was a problem hiding this comment.
Looks good! Now that we confirmed the images update, the last change (🤞) would be to point to file paths to the trace extension master instead of your branch.
Thank you for all the updates! I didn't expect there to be so much back and forth for a readme update 😀
modify Gitpod live demo to minimize user confusion because Gitpod changed their branding. Fixes eclipse-cdt-cloud#350 Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
IbrahimFradj
force-pushed
the
IF-gitpodDemo
branch
from
762bfca to
0e7f326
Compare
|
@ebugden with great pleasure. i changed the path of files to trace extension master |
Update Gitpod live demo and screenshots to minimize user confusion because Gitpod changed their branding.
Fixes #350
I changed paths in ReadMe to my branch to see the result and you can review
Before merging: we should update media file paths to theia-ide/theia-trace-extension and change the branch If-gitpodDemo to matser (https://raw.githubusercontent.com/theia-ide/theia-trace-extension/master/doc/images/gitpod-live-demo-setup.gif)
Here is the result
Signed-off-by: Ibrahim Fradj ibrahim.fradj@ericsson.com