Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flame Chart not populated properly for LTTng UST traces with call stack data #168

Closed
bhufmann opened this issue Oct 23, 2020 · 2 comments · Fixed by #169
Closed

Flame Chart not populated properly for LTTng UST traces with call stack data #168

bhufmann opened this issue Oct 23, 2020 · 2 comments · Fixed by #169
Labels
bug Something isn't working Theia UI frontend
Milestone

Comments

@bhufmann
Copy link
Collaborator

The Flame Chart is currently not populated properly. Most of the function states are not shown. Only a view are visible as well as some "GAP" states.

image

@bhufmann bhufmann added bug Something isn't working Theia UI frontend labels Oct 23, 2020
@bhufmann bhufmann added this to the First MVP milestone Oct 23, 2020
@bhufmann
Copy link
Collaborator Author

bhufmann commented Oct 23, 2020

After some debugging, it turns out that the there was an exception generated when trying to calculate an array index using a key and modulo operation for the coloring. The uncaught exception is caused because the key (parentKey below) is negative:

style = backupStyles[(hash(stateStyle.parentKey) as number % backupStyles.length)];

This uncaught exception actually, causes any updates to retrieve data from the server to not be executed because a flag is not reset. This is actually in the timeline-chart implementation. A fix needs to be done to always reset the flag.
https://github.com/theia-ide/timeline-chart/blob/006aac473e90a00c4abbf1a7088a5d788ac1c6de/timeline-chart/src/layer/time-graph-chart.ts#L222

@bhufmann
Copy link
Collaborator Author

Note that the data provider for the flame graph should also provide the styles for the coloring, but that is not in the scope of this issue.

bhufmann added a commit that referenced this issue Oct 26, 2020
Fixes #168

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
hriday-panchasara pushed a commit to hriday-panchasara/theia-trace-extension that referenced this issue Nov 10, 2021
Fixes eclipse-cdt-cloud#168

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Theia UI frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant