Skip to content

Commit

Permalink
[viewer-prototype] Use Theia re-export rather than importing inversif…
Browse files Browse the repository at this point in the history
…y directly

This way, we re-use inversify through @theia/core, rather than importing it without
declaring it as a dependency in our package.json (i.e. implicit dependency).

This also follows Theia's guidance regarding using their re-exports:
https://github.com/eclipse-theia/theia/tree/master/packages/core#re-exports-mechanism

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
  • Loading branch information
marcdumais-work committed Mar 15, 2024
1 parent d1616c4 commit d88ea47
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { FrontendApplicationContribution } from '@theia/core/lib/browser';
import { inject, injectable } from 'inversify';
import { inject, injectable } from '@theia/core/shared/inversify';
import { PortPreferenceProxy, TRACE_VIEWER_DEFAULT_PORT } from '../common/trace-server-url-provider';
import { TracePreferences, TRACE_PORT } from './trace-server-preference';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable @typescript-eslint/no-non-null-assertion */
import { injectable } from 'inversify';
import { injectable } from '@theia/core/shared/inversify';
import { TraceServerConnectionStatusClient } from '../common/trace-server-connection-status';

type Listener = (serverStatus: boolean) => void;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { injectable, inject } from 'inversify';
import { injectable, inject } from '@theia/core/shared/inversify';
import { ExperimentManager } from 'traceviewer-base/lib/experiment-manager';
import { TraceManager } from 'traceviewer-base/lib/trace-manager';
import { ITspClientProvider } from 'traceviewer-base/lib/tsp-client-provider';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { injectable } from 'inversify';
import { injectable } from '@theia/core/shared/inversify';
import { RestClient } from 'tsp-typescript-client/lib/protocol/rest-client';
import {
TraceServerConnectionStatusBackend,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { inject, injectable } from 'inversify';
import { inject, injectable } from '@theia/core/shared/inversify';
import { TraceServerConfigService } from '../common/trace-server-config';
import {
TraceServerUrlProvider,
Expand Down

0 comments on commit d88ea47

Please sign in to comment.