Skip to content

Commit

Permalink
trace-viewer: Remove onAfterShow causing event loop
Browse files Browse the repository at this point in the history
Before this change, opening two traces then moving one in its own panel
caused an infinite focus loop between these two. That event loop seemed
to have been caused by onAfterShow firing an extra event during that
move action.

Removing that overriding method in TraceViewerWidget fixes that event
loop, lending the moved trace tab in focus as expected (in its own
panel). No evidence of requiring that method in other cases was found.

Fixes #736.

Signed-off-by: Marco Miller <marco.miller@ericsson.com>
  • Loading branch information
marco-miller committed May 10, 2022
1 parent ac54cd2 commit 77de32e
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -284,13 +284,6 @@ export class TraceViewerWidget extends ReactWidget implements StatefulWidget {
}
}

onAfterShow(msg: Message): void {
super.onAfterShow(msg);
if (this.openedExperiment) {
signalManager().fireTraceViewerTabActivatedSignal(this.openedExperiment);
}
}

onActivateRequest(msg: Message): void {
super.onActivateRequest(msg);
if (this.openedExperiment) {
Expand Down

0 comments on commit 77de32e

Please sign in to comment.