Skip to content

Commit

Permalink
GraphQL ADR: Undo link from server to filter action
Browse files Browse the repository at this point in the history
As there is no currently supported way for trace-server to execute or
apply filters. Such actions aren't part of current TSP, thus out of this
current GraphQL ADR scope.

This removal requires adding a link towards Query Parameters, from this
amended section, for further clarification purposes. Shorten that line
accordingly, based on the surrounding lines lengths for maintainability.

Keep the provisioning or amend of the sibling Launching analysis part
for another commit.

Signed-off-by: Marco Miller <marco.miller@ericsson.com>
  • Loading branch information
marco-miller committed Mar 1, 2022
1 parent ae32209 commit 502fa68
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions doc/adr/0002-GraphQL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# 2. GraphQL

Date: 2022-02-15
Date: 2022-02-24

## Status

Expand Down Expand Up @@ -45,14 +45,12 @@ Expected [TSP][tsp] features support.
* Current TSP `/table/{outputId}/lines` is the main endpoint supporting [trace-server][inc] filtering.
* Such filtering is optionally requested by clients through TSP [Query Parameters](#query-parameters).
* A model tagging the matching table lines and columns (or cells) gets returned as a response.
* Server may also deduce the [applicable actions](#executing-actions) from those tags.
* This is captured by `trace-server`'s `TableLine` abstractions and implementations.
* GraphQL's ability to support these (e.g., event) table search filters is therefore discussed below.
* GraphQL's ability to support event table search filters is thus [discussed below](#query-parameters).
* Filtering or searching an event table is based on the requested search expressions and direction.

#### Executing actions

* Applying filter.
* Launching analysis, e.g. follow CPU or Thread for Critical Path analysis.

We need to check which REST endpoints these are currently, first.
Expand Down

0 comments on commit 502fa68

Please sign in to comment.