Skip to content

Commit

Permalink
GraphQL ADR: Close current proposal after reviewed
Browse files Browse the repository at this point in the history
Now that the proposal is done reviewing internally, close it for the
time being while documenting this decision.

Signed-off-by: Marco Miller <marco.miller@ericsson.com>
  • Loading branch information
marco-miller committed Apr 28, 2022
1 parent 4f8ffae commit 0cf2bd8
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions doc/adr/0002-GraphQL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# 2. GraphQL

Date: 2022-04-05
Date: 2022-04-26

## Status

Expand Down Expand Up @@ -352,6 +352,13 @@ Now that course focuses on a JavaScript-based stack,

1. We need to discuss the aforementioned potential alternatives or more,
1. then document this section accordingly.
1. For now though, it has been decided to not pursue GraphQL because:
1. there is no known client that requires solving a TSP usability issue today;
1. a new TSP client might be required as a worthy GraphQL ramp-up experience.
1. Some client benefit(s) that can be short-term enough is required for this.
1. There should be no significant server rewrite without a client benefit.
1. There should be no significant resolver writing effort without benefits.
1. TSP (HTTP) already has options that support working around REST constraints.

## Consequences

Expand Down Expand Up @@ -392,9 +399,8 @@ Each number referring to an aforementioned (previously numbered) risk.

## Next steps

1. Review this ADR proposal jointly, then decide on if [Accepting][legend] it or not.
1. Back-log potential (currently known, missing) work items if any at this stage.
1. Then potentially consider [Apollo's expected graph principles][princ] to apply.
1. Resume the work on this GraphQL proposal, if ever (once) deemed necessary.
1. Potentially consider [Apollo's expected graph principles][princ] to apply.
[alt]: https://www.robinwieruch.de/why-graphql-advantages-disadvantages-alternatives/#graphql-alternatives
[analytics]: https://www.howtographql.com/basics/1-graphql-is-the-better-rest
Expand Down

0 comments on commit 0cf2bd8

Please sign in to comment.