Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to easily pause target and wait for it to be ready #295

Closed
jonahgraham opened this issue Sep 19, 2023 · 3 comments · Fixed by #338 or #339
Closed

Add API to easily pause target and wait for it to be ready #295

jonahgraham opened this issue Sep 19, 2023 · 3 comments · Fixed by #338 or #339

Comments

@jonahgraham
Copy link
Contributor

There are a couple of places in the code where we wait for target to be suspended after issuing pause to ensure that we are operating on a suspended target. However those current places (such as use of waitPauseNeeded) are not very conducive for new places, such as what is needed by #292

This is an API feature request to add such support in a generic manner.

jonahgraham pushed a commit to XingMicrochip/cdt-gdb-adapter that referenced this issue Sep 19, 2023
While this change does not wait for the target to be paused
it slightly slows down how long after interrupt is sent that
disconnect is sent.

See also eclipse-cdt-cloud#295
jonahgraham pushed a commit that referenced this issue Sep 19, 2023
While this change does not wait for the target to be paused
it slightly slows down how long after interrupt is sent that
disconnect is sent.

See also #295
@Luke-zhang-mchp
Copy link
Contributor

Hi @jonahgraham, I'd like to take up this issue. After looking around, I'm thinking I can just add a method in GDBDebugSessionBase that waits for the pause. I'll submit a draft PR soon, let me know what you think.

@jonahgraham
Copy link
Contributor Author

@Luke-zhang-mchp that sounds great. Let me know if you have any questions as you implement this.

@jonahgraham
Copy link
Contributor Author

We have a nice new API now for pausing/resuming (if necessary) so that operations that require a paused target can operate properly. Thanks @Luke-zhang-mchp for picking this up.

See GDBDebugSessionBase.pauseIfNeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants