Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclipse buildpack-deps image #37

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Eclipse buildpack-deps image #37

merged 1 commit into from
Mar 27, 2024

Conversation

heurtematte
Copy link
Contributor

This pull request introduces a new Docker image based on the buildpack-deps image, with some specific tools/packages for Eclipse CBI environment.

  • Added a new Dockerfile to build a new image based on buildpack-deps ubuntu noble version
  • Installed Eclipse specific tools and dependencies required for Eclipse-related CBI builds.

Benefits:

  • A global build image will reduce the maintenance burden of a dedicated image per package, especially in gitlab CI environment. (micro service approach)
  • Inheriting the image from a well-known and maintained Docker image will allow focus on specific Eclipse CBI packages/tools and take benefit of the community.

@heurtematte heurtematte force-pushed the feat/eclipse_buildpack-deps branch from 60ac7d5 to 3dc508b Compare March 25, 2024 14:31
@heurtematte heurtematte marked this pull request as draft March 25, 2024 14:40
@heurtematte heurtematte marked this pull request as ready for review March 27, 2024 10:58
@heurtematte heurtematte requested a review from fredg02 March 27, 2024 10:58
@fredg02
Copy link
Contributor

fredg02 commented Mar 27, 2024

Can you resolve the conflict in the Jenkinsfile?

@heurtematte
feat: add a specific eclipse image based on buildpack-deps
bfb6721 
Signed-off-by: sebastien.heurtematte <sebastien.heurtematte@eclipse-foundation.org>
@heurtematte heurtematte force-pushed the feat/eclipse_buildpack-deps branch from 3dc508b to bfb6721 Compare March 27, 2024 11:46
@heurtematte
Copy link
Contributor Author

done! and build ok.

@fredg02 fredg02 merged commit eff7afc into master Mar 27, 2024
3 checks passed
@fredg02 fredg02 deleted the feat/eclipse_buildpack-deps branch March 27, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredg02 fredg02 fredg02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heurtematte @fredg02