Allow to get the target and the certificate path from X509CertPath #374
Conversation
|
IMHO it would be sufficient to add a getCertPath method to |
AlexITC
changed the title
|
@sophokles73 you are right, its quite simpler in this way, I changed all the code, thanks! |
| * | ||
| * @return The path. | ||
| */ | ||
| public CertPath getPath() { return path; } |
There was a problem hiding this comment.
please put the method body on its own line (like in the the rest of the class)
There was a problem hiding this comment.
the method body is already in the same line as the method signature, isn't it?
There was a problem hiding this comment.
what I mean is:
public CertPath getPath() {
return path;
}
There was a problem hiding this comment.
sure, I placed it this way following the style of getName, I'll change it soon, thanks.
| /** | ||
| * Gets the asserted identity of this certificate path. | ||
| * | ||
| * @return The subject. |
There was a problem hiding this comment.
this is not the subject but the whole certificate
| @@ -664,7 +664,7 @@ public Principal getPeerIdentity() { | |||
| /** | |||
| * Sets the authenticated peer's identity. | |||
| * | |||
| * @param the identity | |||
| * @param peerIdentity the identity | |||
There was a problem hiding this comment.
this doesn't seem to be related to the other changes.
next time, please create a separate PR for it
Signed-off-by: Alexis Hernandez <alexis22229@gmail.com>
|
@sophokles73 I just noticed the |
Signed-off-by: Alexis Hernandez alexis22229@gmail.com