Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the docx emitter to add padding calculation to BIRT element "label" (#1941) #1942

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Enhance the docx emitter to add padding calculation to BIRT element "label" (#1941) #1942

merged 1 commit into from
Oct 21, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added this to the 4.18 milestone Oct 20, 2024
@speckyspooky speckyspooky added the Enhancement Small change to improve the current supported functionality label Oct 20, 2024
@speckyspooky speckyspooky self-assigned this Oct 20, 2024
@speckyspooky speckyspooky requested a review from merks October 20, 2024 18:50
@speckyspooky
Copy link
Contributor Author

Hi @merks,

I have seen that my PR was crashing very early with the message
that a dependency wasn't available at repository side: org.mortbay.jasper.apache-el/9.0.90

Original message:
Failed to resolve target definition file:/home/runner/work/birt/birt/build/org.eclipse.birt.target/org.eclipse.birt.target.target: Could not find "org.mortbay.jasper.apache-el/9.0.90" in the repositories of the current location

Have you an idea how we can solve the missing dependency?

Thanks in advance
Thomas

@merks merks mentioned this pull request Oct 21, 2024
Merged
@merks merks force-pushed the enhance_docx_label_padding_1941 branch from 3732106 to a2b0dd4 Compare October 21, 2024 05:48
merks
merks approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but I'm not good to judge what's correct just looking at the code...

@speckyspooky speckyspooky merged commit a739626 into eclipse-birt:master Oct 21, 2024
3 checks passed
@speckyspooky speckyspooky mentioned this pull request Oct 21, 2024
Closed
@speckyspooky speckyspooky mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Enhancement Small change to improve the current supported functionality
Projects
None yet
Milestone
4.18
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @merks