ci(docker): Fix calculating the ORT Server version #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `fetch-depth` to `0` to checkout the whole commit history including tags. This is required to correctly calculate the ORT Server version. Fixes #1610. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
mnonnenmacher
requested review from
bs-ondem,
MarcelBochtler,
nnobelis,
oheger-bosch and
sschuberth
as code owners
sschuberth
reviewed
Dec 10, 2024
| @@ -84,6 +84,8 @@ jobs: | |||
| steps: | |||
| - name: Checkout Repository | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
Would fetch-tags: true work as well?
There was a problem hiding this comment.
I guess not, at least when used instead of fetch-depth: 0.
There was a problem hiding this comment.
I saw it as well but then found actions/checkout#1471, so I just used the same config as in the release workflow.
sschuberth
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
fetch-depthto0to checkout the whole commit history including tags. This is required to correctly calculate the ORT Server version.Fixes #1610.