-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum php version to 8.2 #195
base: main
Are you sure you want to change the base?
Conversation
This would close #194 |
can you please add https://github.com/echolabsdev/prism/blob/main/.github/workflows/tests.yml#L18 php8.2 in test matrix so we can be sure if the code works on php 8.2 ? |
@pushpak1300 Yes, of course, that makes sense. Do you think the other formatting/phpstan workflows should also be set to 8.2 ? |
I'm okay with this change, I think we can adopt Laravel minimums. I'll take a closer look this afternoon |
I think we also need to update the formatting GH Action to remove the peck check as well. |
I do have a PR in with Peck to do similar, maybe we give it a few days to see if there is movement over there? |
Yeah, lets hold off a few days and see what happens |
Preview deployments for prism ⚡️
Commit: Deployment ID: Static site name: |
I just asked Nuno on his twitch stream about the likelihood of approving a php8.2 PR to Peck, and he didn't seem into it. I've added a commit to remove it from the workflow... |
Hmm, maybe keep holding on this. A maintainer over at Peck has given the thumbs up on my PR there, and suggested it get merged in. That hasn't happened yet, so I would have to re-add Peck back in here. Let me know if you'd prefer me to create a new PR to keep things clean, or happy for me to add another commit bringing back Peck if/when that PR gets merged. |
Unfortunately peckphp/peck has a minimum version of php8.3, so could not be included. I could find no other reason not have the minimum version set to 8.2.