Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum php version to 8.2 #195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

da-mask
Copy link

@da-mask da-mask commented Feb 17, 2025

Unfortunately peckphp/peck has a minimum version of php8.3, so could not be included. I could find no other reason not have the minimum version set to 8.2.

@da-mask
Copy link
Author

da-mask commented Feb 17, 2025

This would close #194

@pushpak1300
Copy link
Contributor

pushpak1300 commented Feb 17, 2025

can you please add https://github.com/echolabsdev/prism/blob/main/.github/workflows/tests.yml#L18 php8.2 in test matrix so we can be sure if the code works on php 8.2 ?

@da-mask
Copy link
Author

da-mask commented Feb 17, 2025

@pushpak1300 Yes, of course, that makes sense. Do you think the other formatting/phpstan workflows should also be set to 8.2 ?

@pushpak1300
Copy link
Contributor

@da-mask I don't think that is needed. Let's wait for @sixlive and see what he thinks ?

@sixlive
Copy link
Contributor

sixlive commented Feb 18, 2025

I'm okay with this change, I think we can adopt Laravel minimums. I'll take a closer look this afternoon

@sixlive
Copy link
Contributor

sixlive commented Feb 18, 2025

I think we also need to update the formatting GH Action to remove the peck check as well.

@da-mask
Copy link
Author

da-mask commented Feb 18, 2025

I do have a PR in with Peck to do similar, maybe we give it a few days to see if there is movement over there?

@sixlive
Copy link
Contributor

sixlive commented Feb 18, 2025

Yeah, lets hold off a few days and see what happens

Copy link

kinsta bot commented Feb 18, 2025

Preview deployments for prism ⚡️

Status Branch preview Commit preview
❌ Failed to deploy N/A N/A

Commit: a570c52164d8ebef72d11e590ff658f3ff3a3d76

Deployment ID: 99e7007d-95ce-45b3-b36e-660ee5b7d35f

Static site name: prism-97nz9

@da-mask
Copy link
Author

da-mask commented Feb 18, 2025

I just asked Nuno on his twitch stream about the likelihood of approving a php8.2 PR to Peck, and he didn't seem into it. I've added a commit to remove it from the workflow...

@da-mask
Copy link
Author

da-mask commented Feb 23, 2025

Hmm, maybe keep holding on this. A maintainer over at Peck has given the thumbs up on my PR there, and suggested it get merged in. That hasn't happened yet, so I would have to re-add Peck back in here. Let me know if you'd prefer me to create a new PR to keep things clean, or happy for me to add another commit bringing back Peck if/when that PR gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants