feat: Make downloaded filenames consistent between runs #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The downloaded filenames change between multiple runs which make it hard to track changes. This will make them consistent by prefixing a the hashed url-path to the filename. Using just the filename would not work if a notion page contains e.g. two different images with the same filename.
echo724
changed the title
|
Thank you for your contribution on the notion2md!! I was busy so it took some time for me to review this. I approved and merged this to the main branch of the notion2md. Again, Thank you for your interest on the Notion2md |
|
🎉 This issue has been resolved in version 2.8.0 🎉 The release is available on PyPI and GitHub. |
YouXam
pushed a commit
to YouXam/notion2md
that referenced
this pull request
Nov 3, 2023
The downloaded filenames change between multiple runs which make it hard to track changes. This will make them consistent by prefixing a the hashed url-path to the filename. Using just the filename would not work if a notion page contains e.g. two different images with the same filename. Co-authored-by: Felix <fkunzweiler@xps-felix.fritz.box>
YouXam
pushed a commit
to YouXam/notion2md
that referenced
this pull request
Nov 3, 2023
## [2.8.0](echo724/notion2md@v2.7.6...v2.8.0) (2022-10-14) ### Features * Make downloaded filenames consistent between runs ([echo724#38](echo724#38)) ([30e8f0b](echo724@30e8f0b)) ### Bug Fixes * Fixed [echo724#40](echo724#40) due to the update of Notion API ([echo724#42](echo724#42)) ([1a63351](echo724@1a63351))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloaded filenames change between multiple runs which make it hard
to track changes.
This will make them consistent by prefixing a the hashed url-path to the
filename. Using just the filename would not work if a notion page
contains e.g. two different images with the same filename.