Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more column types to BioLogic.py #71

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

chatcannon
Copy link
Collaborator

@chatcannon chatcannon commented Jun 5, 2022

This was created as chatcannon#1 by @GhostDeini and has been moved to the main repo.

Added "control/mA", "Q charge/discharge/mA.h", "step time/s", "Q charge/mA.h", "Q discharge/mA.h", "Efficiency/%", "Capacity/mA.h" to possible fieldnames in fieldname_to_dtype(fieldname). Also in VMPdata_colID_dtype_map.

Added "control/mA", "Q charge/discharge/mA.h", "step time/s", "Q charge/mA.h", "Q discharge/mA.h", "Efficiency/%", "Capacity/mA.h" to possible fieldnames in fieldname_to_dtype(fieldname). Also in VMPdata_colID_dtype_map.
@chatcannon
Copy link
Collaborator Author

@GhostDeini Do you have any example data files which include these columns?

@chatcannon chatcannon changed the title Update BioLogic.py Add more column types to BioLogic.py Nov 30, 2022
@chatcannon chatcannon merged commit e5a1b84 into echemdata:master Nov 30, 2022
@JhonFlash3008
Copy link
Contributor

JhonFlash3008 commented Feb 12, 2024

Hey ! I'm working on trying to import all kinds of mpr files in order to spot the possible errors and particularly the missing col IDs. I compare the mpr files with their mpt extract in order to do so.
I found these ones in particular :

498: ("|Ece h2|/V", "<f4"),
 499: ("|Ece h3|/V", "<f4"),
 500: ("|Ece h4|/V", "<f4"),
 501: ("|Ece h5|/V", "<f4"),
 502: ("|Ece h6|/V", "<f4"),
 503: ("|Ece h7|/V", "<f4"),

But they already had a corresponding ID :

    499: ('Q discharge/mA.h', '<f8'),
    500: ('step time/s', '<f8'),
    501: ('Efficiency/%', '<f8'),
    502: ('Capacity/mA.h', '<f8')

I wasn't sure if it was ok to replace the existing ones but apparently they were added with this merge and do not have a specific example file ?

@chatcannon
Copy link
Collaborator Author

I wasn't sure if it was ok to replace the existing ones but apparently they were added with this merge and do not have a specific example file ?

If they don't have an example file and yours do then let's go with your version. I don't have any other way of verifying it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants