Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added colIDs 74 and 462 to VMPdata_colID_dtype_map #43

Merged
merged 3 commits into from
Jul 3, 2020
Merged

Added colIDs 74 and 462 to VMPdata_colID_dtype_map #43

merged 3 commits into from
Jul 3, 2020

Conversation

nhshetty-99
Copy link
Contributor

No description provided.

bcolsen
bcolsen requested changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@bcolsen bcolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good.

Can you put the new lines in numerical order with the rest of the dictionary to help keep things organized?

Thank you

bcolsen
bcolsen approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@bcolsen bcolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@chatcannon
Copy link
Collaborator

The build passed - see https://travis-ci.org/github/echemdata/galvani/builds/702922938 - but somehow the status was not updated on the pull request. I restarted the build; hopefully that will fix things.

@chatcannon chatcannon merged commit e67edf9 into echemdata:master Jul 3, 2020
@chatcannon chatcannon linked an issue Jul 3, 2020 that may be closed by this pull request
Unable to parse all columns in .mpr file #42
Closed
@chatcannon chatcannon mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcolsen bcolsen bcolsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to parse all columns in .mpr file
3 participants
@nhshetty-99 @chatcannon @bcolsen