Skip to content

Commit

Permalink
Fix silently ignoring file path in pvsystem.retrieve_sam when `name…
Browse files Browse the repository at this point in the history
…` is provided (pvlib#2020)

* My approach to the issue

* Deprecate previous parameters

* No reason to over-engineer, right?

* Update v0.10.5.rst

* Update pvsystem.py

* Improve error handling

* Add ppl involved

* kevin's suggestions
  • Loading branch information
echedey-ls committed May 23, 2024
1 parent ec717a9 commit a357c11
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions docs/sphinx/source/whatsnew/v0.10.5.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ Bug fixes
* Fixed :py:func:`pvlib.pvsystem.retrieve_sam` silently ignoring the ``path`` parameter
when ``name`` was provided. Now an exception is raised requesting to only provide one
of the two parameters. (:issue:`2018`, :pull:`2020`)
* Fixed :py:func:`pvlib.pvsystem.retrieve_sam` silently ignoring the `path` parameter
when `name` was provided. Now an exception is raised requesting to only provide one
of the two parameters. (:issue:`2018`, :pull:`2020`)


Testing
~~~~~~~


Documentation
Expand All @@ -57,3 +64,5 @@ Contributors
* Scott Meredith (:ghuser:`smmeredith`)
* Alexander Morgan (:ghuser:`alexandermorgan`)
* Kevin Anderson (:ghuser:`kandersolar`)
* :ghuser:`apct69`
* Mark Mikofski (:ghuser:`mikofski`)

0 comments on commit a357c11

Please sign in to comment.