PSR-17 and PSR-18 compability #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use psr-18 http-client interfaces, instead.
Use PSR-17 http-factory instead. Guzzle is the default, if present.
|
I still see catching GuzzleExceptions. They will get tackled as well. |
|
Multipart upload is another thing to be solved. As we are currently only reading from Canto, we don't have any real-world scenario to test on. Maybe one of the maintainers can help. Left a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are going to use this library in our Symfony full-stack project, but we don't want to require an additional http-client, I've abstracted everything tightly coupled to guzzle out and replaced it with PSR-18 ClientInterfaces and PSR-17 RequestFactoryInterfaces.
This also adds a BC Break, since the Client now also implements the
Psr\Http\Message\RequestFactoryInterface, soPsr\Http\Message\RequestInterfacecompatible requests can be created via the Client itself.The
RequestFactoryInterfaceto be used can be passed via the ClientOptionshttpRequestFactorykey and defaults to an anonymous implementation, returning a\GuzzleHttp\Psr7\Request, if guzzle is installed.If guzzle is not installed and you forget to pass
httpClientandhttpRequestFactoryto the ClientOptions, it will throw dedicated HttpClientExceptions.I moved
guzzlehttp/guzzletorequire-dev, so it can be used for testing, but suggest it to be installed as a default http-client solution. Projects that installed an older version of this library may not break, since they already haveguzzlehttp/guzzleinstalled as a dependency from the old version, but they must require it explicitly from now on.