Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/preserving poll #2936

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Nt/preserving poll #2936

merged 3 commits into from
Oct 28, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Oct 28, 2024 •
edited
Loading

What does this PR?

Preserves poll after wave editing

  1. keeps the content type and post type properties from old jsonMeta
  2. hides poll wizard from post edit mode to restrict users from updating or adding poll in edit mode

Issue number

https://discord.com/channels/@me/920267778190086205/1299968103601541200

Screenshots/Video

This is an edited version of wave with preserved poll data
Screenshot 2024-10-28 at 17 11 33

@noumantahir noumantahir requested a review from feruzm October 28, 2024 12:29
feruzm
feruzm approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit ab7452a into development Oct 28, 2024
@feruzm feruzm deleted the nt/preserving-poll branch October 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm