Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/padding tweaks #2934

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Nt/padding tweaks #2934

merged 3 commits into from
Oct 22, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

  • fine tuned bottom tab bar padding for android
  • made top header padding consistent across devices

Screenshots/Video

BEFORE
Screenshot 2024-10-22 at 19 31 27

AFTER
Screenshot 2024-10-22 at 19 31 06

@noumantahir noumantahir requested a review from feruzm October 22, 2024 14:32
feruzm
feruzm approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit c48c82e into development Oct 22, 2024
@feruzm feruzm deleted the nt/padding-tweaks branch October 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm