Nt/orientation tweaks #2924
Merged
Nt/orientation tweaks #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
Laying down a base for tablet support, essentially avoid relying on static dimensions like getWindowDimension and deviceWith constants.
Also fixes a number of orientation related glitches that were appearing in mobile side, details can be checked in the issue link.
After PR is merged, we should seep the app to see if it did not affect any component formation in a bad way, I did encounter some and fixed them right away, I do expect more but there should not be many ideally.
Issue number
https://github.com/orgs/ecency/projects/4/views/1?pane=issue&itemId=81468842