Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/user filters #2922

Merged
merged 39 commits into from
Sep 27, 2024
Merged

Nt/user filters #2922

merged 39 commits into from
Sep 27, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Sep 25, 2024 •
edited
Loading

What does this PR?

  • Added support for customisable feed filters with reordering support
  • Updated guest and default feed filters
  • Added user specific optional feed filters blog, posts and comments
  • added walkthrough marker component, that renders red marker for one up till it is intercepted, check demo video

what started off a simple feature replicated, ended up giving real nightmares. Apparently draggable flat list is not very cooperative when used out side of react-navigation.

Screenshots/Video

Screen.Recording.2024-09-26.at.18.11.57.mov

@noumantahir
added user related tabs options, setting blog as default feed tab
3e29db9
@noumantahir
rendering comments tab content in main feed tab when selected
411e025
@noumantahir
removed unused getFor prop
f30bb40
@noumantahir
support for guest filters for non-user app session
cc41794
@noumantahir
stremlined tabbed posts props
c81e5f3
@noumantahir
get rid of stackedTabs prop
348fd91
@noumantahir
updated feed screen for follow new tabbed posts props
8409c6c
@noumantahir
discard guest filtesr in favour of already available global filters
7e3d31d
@noumantahir
updated tabbedposts props in community, profile and tab screens
cccd970
@noumantahir
fix global filters typo
3a84c54
@noumantahir
lint
805f8c2
@noumantahir
converted draggabel selection list used in assetsSelect modal into re…
a096e77 
…useable one
@noumantahir
added custmise feed tab modal react-navigation modal
3243646
@noumantahir
implemented selection list in tabs customisation
d21e2ae
@noumantahir
update customise feed filters component to use new selection list com…
f126816 
…ponent
@noumantahir
reverted feedtabbar to use old sheet based tab selector
54965e8
@noumantahir noumantahir requested a review from feruzm September 25, 2024 14:31
@noumantahir noumantahir marked this pull request as ready for review September 26, 2024 09:04
@feruzm feruzm merged commit efe327c into development Sep 27, 2024
@feruzm feruzm deleted the nt/user-filters branch September 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm