Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/feed filters #2921

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Nt/feed filters #2921

merged 8 commits into from
Sep 20, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Sep 19, 2024

What does this PR?

  • replaced tab view of feed screen with more maintained package react-native-tab-view
  • added support for scrollable tab view
  • dynamically enable/disable scroll based on number of selected filters
  • support for selecting more than 3 filters
  • added edit tabs button to right of tabs

Challenges

  • using base behaviour of tab bar that comes with tab-view package is making it difficult to add action buttons with tab bar as we have been doing before. We can chose to use or previous tabBar but with that we will lose ability to auto reveal hidden tabs as portrayed in video
  • response to tab touch and change tabs seems slow, it could either be dev mode issue, or need to add better optimisation, right now only drafted a solution for testing.

Issue number

https://github.com/orgs/ecency/projects/4/views/1?pane=issue&itemId=80470260

Screenshots/Video

Screen.Recording.2024-09-20.at.10.38.07.mov

@noumantahir noumantahir requested a review from feruzm September 20, 2024 05:40
@noumantahir noumantahir marked this pull request as ready for review September 20, 2024 05:41
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 89a3451 into development Sep 20, 2024
@feruzm feruzm deleted the nt/feed-filters branch September 20, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants