Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/notifications ordering #2807

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Nt/notifications ordering #2807

merged 5 commits into from
Dec 19, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

  • using gk property for time passed calculation (as used in ecency-vision)
  • refactored component to functional base
  • using memo to save uanessacry processing
  • using section list instead of flat list, kept the sections same as before (Recent, Yesterday, This Week and so on)
  • fixed logic for Last Week calculation (probably the primary reason causing sorting issue)
  • Renamed Label from Older than month to Last month & older as older than month seems 30+ days but section starts prior to first of current month.

Issue number

https://github.com/orgs/ecency/projects/2#card-91379167

Screenshots/Video

Screen.Recording.2023-12-19.at.17.43.37.mov

@noumantahir noumantahir requested a review from feruzm December 19, 2023 12:48
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit e1dcd06 into development Dec 19, 2023
@feruzm feruzm deleted the nt/notifications-ordering branch December 19, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants