Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hive uri QR support #2755

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Improve hive uri QR support #2755

merged 4 commits into from
Sep 28, 2023

Conversation

aliseyalvi
Copy link
Collaborator

@aliseyalvi aliseyalvi commented Sep 17, 2023

What does this PR?

  • added operations.json to validate From/signer field in operation object
  • added validation for amount field in operation object
  • added error handler to format blockchain exceptions to parse into readable format
  • added validation for key required for transaction to perform

Issue number

fixes #2756
https://discord.com/channels/@me/920267778190086205/1149266143979245628

Screenshots/Video

Screenrecorder-2023-09-17-13-06-47-380.mp4
Screenrecorder-2023-09-17-13-05-40-501.mp4

…ject

* added validation for amount field in operation object
* added error handler to format blockchain exceptions to parse into readable format
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direct is good, a few refactoring with testing more and I think we should be good...

src/utils/hive-uri.ts Show resolved Hide resolved
src/utils/hive-uri.ts Outdated Show resolved Hide resolved
src/components/qrModal/qrModalView.tsx Outdated Show resolved Hide resolved
@noumantahir
Copy link
Collaborator

@feruzm seems good from my side... please review...

@noumantahir noumantahir self-requested a review September 27, 2023 12:39
@feruzm feruzm merged commit 5228930 into development Sep 28, 2023
@feruzm feruzm deleted the sa/improve-hive-uri-support branch September 28, 2023 04:01
@aliseyalvi aliseyalvi changed the title [WIP] Improve hive uri QR support Improve hive uri QR support Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch resolve transaction, integrate json to identify empty signer field.
3 participants