-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency php to v8.2.6 #3457
Conversation
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Had to upgrade alpine from 3.16 to 3.18. PHP 8.2.6 images are not published anymore with alpine 3.16. |
renovate.json
Outdated
"matchPackageNames": [ | ||
"alpine" | ||
], | ||
"allowedVersions": "3.16" | ||
"allowedVersions": "3.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would remove this constraint directly.
How is this not a problem anymore with #3246 ?
do we have a newer icu package in the ci automagically with this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it, it is a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 593ff55
renovate.json
Outdated
"matchPackageNames": [ | ||
"alpine" | ||
], | ||
"allowedVersions": "3.16" | ||
"allowedVersions": "3.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it, it is a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BacLuc is it safe to allow arbitrary alpine upgrades now? Will they continue supporting your pinned icu version for the forseeable future?
Thanks @BacLuc for remembering that this was an issue. I didn't recall before, why we fixed the alpine version. Regarding the question from @carlobeltrame: I don't think it's safe to allow arbitrary alpine upgrades. We should probably keep alpine-version and the icu extension from shivammathur/setup-php in sync. Otherwise we face the issue, that the tests run on CI but not locally. |
As safe as before the breaking change with the icu package. |
Sounds good to me. We just need you again to remember this discussion, once the tests start to break again locally 😄 |
This PR contains the following updates:
8.2.5
->8.2.6
Release Notes
php/php-src
v8.2.6
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.