Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency php to v8.2.6 #3457

Merged
merged 2 commits into from
May 18, 2023
Merged

chore(deps): update dependency php to v8.2.6 #3457

merged 2 commits into from
May 18, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 11, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
php patch 8.2.5 -> 8.2.6

Release Notes

php/php-src

v8.2.6

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label May 11, 2023
@renovate
Copy link
Contributor Author

renovate bot commented May 15, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@usu
Copy link
Member

usu commented May 15, 2023

Had to upgrade alpine from 3.16 to 3.18. PHP 8.2.6 images are not published anymore with alpine 3.16.

@usu usu requested review from carlobeltrame and BacLuc May 15, 2023 17:43
renovate.json Outdated
Comment on lines 106 to 109
"matchPackageNames": [
"alpine"
],
"allowedVersions": "3.16"
"allowedVersions": "3.18"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would remove this constraint directly.
How is this not a problem anymore with #3246 ?
do we have a newer icu package in the ci automagically with this update?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it, it is a problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 593ff55

renovate.json Outdated
Comment on lines 106 to 109
"matchPackageNames": [
"alpine"
],
"allowedVersions": "3.16"
"allowedVersions": "3.18"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it, it is a problem

@BacLuc BacLuc requested review from carlobeltrame and usu May 16, 2023 20:31
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BacLuc is it safe to allow arbitrary alpine upgrades now? Will they continue supporting your pinned icu version for the forseeable future?

@usu
Copy link
Member

usu commented May 16, 2023

@BacLuc is it safe to allow arbitrary alpine upgrades now? Will they continue supporting your pinned icu version for the forseeable future?

Thanks @BacLuc for remembering that this was an issue. I didn't recall before, why we fixed the alpine version.

Regarding the question from @carlobeltrame: I don't think it's safe to allow arbitrary alpine upgrades. We should probably keep alpine-version and the icu extension from shivammathur/setup-php in sync. Otherwise we face the issue, that the tests run on CI but not locally.

@BacLuc
Copy link
Contributor

BacLuc commented May 16, 2023

@BacLuc is it safe to allow arbitrary alpine upgrades now? Will they continue supporting your pinned icu version for the forseeable future?

As safe as before the breaking change with the icu package.
We will see it as soon as our local tests yield different strings than the tests in the ci.
According to the history until 2a43700, we have this problem ca all 2 years, that seems ok to me.
Specially since the users don't care if there is a whitespace or a NBSP.

@usu
Copy link
Member

usu commented May 16, 2023

@BacLuc is it safe to allow arbitrary alpine upgrades now? Will they continue supporting your pinned icu version for the forseeable future?

As safe as before the breaking change with the icu package. We will see it as soon as our local tests yield different strings than the tests in the ci. According to the history until 2a43700, we have this problem ca all 2 years, that seems ok to me. Specially since the users don't care if there is a whitespace or a NBSP.

Sounds good to me. We just need you again to remember this discussion, once the tests start to break again locally 😄

Force intl v73.1 on CI that we use the same version.
There is a breaking change between the default intl (icu) version on
the CI and the alpine image used.
Don't update the intl package automatically because this could not be achieved by @BacLuc until now.

Issue: #3246
@BacLuc BacLuc force-pushed the renovate/php-8.x branch from 593ff55 to cec1210 Compare May 16, 2023 20:58
@BacLuc BacLuc merged commit fdeeb7c into devel May 18, 2023
@BacLuc BacLuc deleted the renovate/php-8.x branch May 18, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants