Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to UA driver #22

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

bjonkman
Copy link

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE

Feature or improvement description
This PR

  • fixes a few minor formatting issues and comments in the code
  • fixes vs-build for UA driver
  • renames and moves the UA_OUTS preprocessor directive to the UA driver. (My Visual Studio preprocessor tried to replace the parameter named UA_OUTS when the preprocessor was named the same thing, so I renamed the directive.)
  • explicitly initializes some of the new InitInp variables

Impacted areas of the software
UA driver

- vs project didn't like a `UA_OUTS` as both a preprocessor directive and value inside a type
- vs project needed LinDyn added to it
- moved override of UA_OUTS to UA driver and added initialization in BEMT & FVW so people could override the value before compiling if they wanted to debug UA inside of AeroDyn.
This would have caused issues when merging with the dev-unstable branch of OpenFAST
- update extension of UA output files
- explicitly initialize `d_34_to_ac`
@ebranlard
Copy link
Owner

Thank you for doing that. I'll merge this in the coming days.

@ebranlard ebranlard merged commit defd8b7 into ebranlard:f/ua-elast-dev Nov 30, 2023
@ebranlard
Copy link
Owner

I'll probably change the interface to allow for the generalized loads scaling factors to be a 3x3 matrix instead of the three coefficients (diagonal elements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants