Add the game Another Crab' s Treasure #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
approved these changes
May 28, 2024
src/model/game/GameManager.ts
Outdated
| "AnotherCrabsTreasure", ["AnotherCrabsTreasure.exe"], "AnotherCrabsTreasure_Data", | ||
| "https://thunderstore.io/c/another-crabs-treasure/api/v1/package/", EXCLUSIONS, | ||
| [new StorePlatformMetadata(StorePlatform.STEAM, "1887840")], "AnotherCrabsTreasure.png", | ||
| GameSelectionDisplayMode.VISIBLE, GameInstanceType.GAME, PackageLoader.BEPINEX, []), |
There was a problem hiding this comment.
Minor: the last empty array, used for sorthands for the text search in the game selection screen could contain "act". IDK if we have a convention for what shorthands to use, but initial letters of the game title would make sense to me.
There was a problem hiding this comment.
I remember Mythic saying "let's not use that"
There was a problem hiding this comment.
In this instance or as a general rule?
anttimaki
force-pushed
the
another-crabs-treasure
branch
from
a9240ce to
24eecff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.