Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ids to buttons (and anchors) in Profiles.vue #1321

Merged
merged 1 commit into from
May 7, 2024
Merged

Add ids to buttons (and anchors) in Profiles.vue #1321

merged 1 commit into from
May 7, 2024

Conversation

VilppeRiskidev
Copy link
Collaborator

  • IDs were added to buttons (and anchors) in Profiles.vue page to make debugging/logging easier
    • modal- prefix was used for modals' buttons

@VilppeRiskidev
Add ids to buttons (and anchors) in Profiles.vue
322a461 
* use `modal-` prefix for the buttons that are inside modals
@VilppeRiskidev VilppeRiskidev requested a review from anttimaki May 6, 2024 19:43
@VilppeRiskidev VilppeRiskidev self-assigned this May 6, 2024
anttimaki
anttimaki approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VilppeRiskidev VilppeRiskidev merged commit 0b3d204 into ebkr:develop May 7, 2024
1 check passed
@VilppeRiskidev VilppeRiskidev deleted the profile-page-button-ids branch May 7, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttimaki anttimaki anttimaki approved these changes

Assignees

@VilppeRiskidev VilppeRiskidev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VilppeRiskidev @anttimaki