Remove ThunderstorePackages helper #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
force-pushed
the
drop-thunderstorepackages
branch
from
8019be4 to
d9b89a7
Compare
- Move package exclusions from ThunderstorePackages to TsModsModule - Drop package exclusions altogether from ApiData and ApiCacheUtils. Caching this information on disk doesn't make much sense since the exclusion list is stored in a local MD file anyway. Furthermore, the disk cache file will soon be removed altogether in favor of IndexedDB - Remove references to ThunderstorePackages from SplashMixin and UtilityMixin. Call related methods directly instead. In the future these methods can be combined behing a single Vuex action - Remove now unused package list related methods from ThunderstorePackages
All remaining code deals with calculating the deprecation status of packages based on the status of their dependencies, so the new name is more descriptive. The methods remain wrapped in a class to make it easier to spy on them in Jest test cases.
anttimaki
force-pushed
the
drop-thunderstorepackages
branch
from
d9b89a7 to
fb4e30a
Compare
MythicManiac
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.