Redesign crate to use inherent impls over traits #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Redesign API as inherent struct implementations with `Deref` and `DerefMut` for handling backwards compatibility * Rename `Version` to `VersionCode`, `ApiVersion` trait to `Version` * Use a single `Entry` type, since the aliases point to the same struct * Add `HasPrevious` trait to recursively determine version compatibility at compile-time * Remove the `prelude` module * Remove the `api` module * Move `CaptureOptions`, `InputButton`, `OverlayBits` to `settings.rs` * Move `DeviceHandle` and `WindowHandle` to `handles.rs` * Remove `RenderDocV###` trait boilerplate code from `renderdoc-derive`
ebkalderon
force-pushed
the
feature/eliminate-api-traits
branch
from
a0c21f9 to
bf17956
Compare
This was referenced May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
HasPrevioustrait to recursively determine version compatibility at compile-time.Changed
DerefandDerefMutfor handling backwards compatibility.VersiontoVersionCode,ApiVersiontrait toVersion.Entrytype, since the aliases point to the same struct.CaptureOptions,InputButton,OverlayBitstosettings.rs.DeviceHandleandWindowHandletohandles.rs.Removed
preludemodule.apimodule.RenderDocV###trait boilerplate code fromrenderdoc-derive.This should improve the user experience for this crate by eliminating the obnoxious trait-heavy abstraction and relying on inherent implementations instead. The code is kept maintainable by using
DerefandDerefMutto overlay semver-compatible API versions together, and with theHasPrevioustrait to determine what methods may be called for which version entirely at compile-time.