Fix undefined behavior and crash in get_capture
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously assumed that the file name of a capture will fit into 128 characters
The previous usage resulted in UB and crashed with `STATUS_HEAP_CORRUPTION` on my system.
ebkalderon
approved these changes
Feb 19, 2023
There was a problem hiding this comment.
Thanks a lot for the submission, @Timbals! These bugs should be fixed in the other branch tracking the rewrite (using CString::from_vec_unchecked() instead of CStr::from_ptr() to reuse the backing Vec<u8> memory), but I'm very happy to see fixes for both issues land on the main branch in the meantime. It's very much appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues in the
get_capturefunctionCString::from_rawincorrectly (see the safety section in the rust docs)This PR fixes both.
The second issue was causing crashes with
STATUS_HEAP_CORRUPTIONfor me because it did some funky things when trying to de-allocate theCString(I think it double-frees and the second free also uses the wrong layout; didn't look into it more).I know you're currently rewriting most of the library but I wanted to share this anyway in case anyone else runs into the same crash.