Linting Fixups #53

MightyAx · 2020-09-25T11:05:39Z

All our UI linting fixups in one place.
I only changed components I understood, so dependencies like the clipboard were left alone.

~~The quicker we review this the better, because this would be a nightmare of a merge conflict.~~
This one will need some testing because of deprecated RxJS functionality.

Deployed to Dev

aaclan-ebi

This is soooo noice!

client/src/app/project-registration/contact-field-group/contact-field-group.component.spec.ts

MightyAx · 2020-09-25T16:22:14Z

For Investigation:

New delay what querying My Projects, All Projects, All Submissions.

…hing to use timer instead.

…s emitted by the source. Useful for search controls.

…lue has changed.

rolando-ebi

Nice, LGTM

If we want all rxjs operators used to exist within pipe()'s, there's a TSLint plugin that can ensure this: https://github.com/ReactiveX/rxjs-tslint

client/src/app/my-projects/my-projects.component.ts

client/src/app/aai/aai.service.ts

client/src/app/shared/services/ontology.service.ts

aaclan-ebi

Wow this is huge PR. Is this already deployed in dev? we should do manual tests and merge soon.

...t/src/app/metadata-schema-form/metadata-field-types/ontology-base/ontology-base.component.ts

client/src/app/my-projects/my-projects.component.ts

client/src/app/template-questionnaire/template-generator.service.ts

client/tsconfig.json

client/src/app/template-questionnaire/template-generator.service.ts

…ame changes. Rather than regenerating everytime anything about the first corresponding contributor changes.

…Subject.next

# Conflicts: # client/src/app/aai/aai.service.ts # client/src/app/project-form/project-form.component.ts # client/src/app/project-registration/project-registration-form/project-registration-form.component.ts # client/src/app/shared/services/ingest.service.ts # client/src/app/template-questionnaire/template-questionnaire.data.spec.ts # client/src/app/template-questionnaire/template-questionnaire.data.ts

client/src/app/shared/guards/user-is-logged-in.guard.ts

MightyAx · 2020-10-07T08:54:13Z

client/src/app/shared/services/ingest.service.ts

@@ -161,43 +169,32 @@ export class IngestService {
    return this.http.get(url);
  }

+  public getAs<T>(url): Observable<T> {
+    return this.http.get(url).pipe(map(data => data as T));


Could change this to:

return this.http.get<T>(url);

client/src/app/project-registration/contact-field-group/contact-field-group.component.ts

client/src/app/project-registration/project-id/project-id.component.ts

aaclan-ebi · 2020-10-07T12:52:36Z

The submission details page is not loading.

MightyAx · 2020-10-07T12:59:19Z

The submission details page is not loading.

Can you post a link @aaclan-ebi? This submission is working for me.
https://dev.contribute.data.humancellatlas.org/submissions/detail?uuid=101b61ed-a7c6-4c76-859b-ad8fcdcdafe4&project=ae6029a8-7446-45fa-ace3-794409cc3656

aaclan-ebi · 2020-10-07T13:05:20Z

The submission details page is not loading.

Can you post a link @aaclan-ebi? This submission is working for me.
https://dev.contribute.data.humancellatlas.org/submissions/detail?uuid=101b61ed-a7c6-4c76-859b-ad8fcdcdafe4&project=ae6029a8-7446-45fa-ace3-794409cc3656

Ah that one's loading when i cleared my cache.

However, I still found a submission which is not loading:
https://dev.contribute.data.humancellatlas.org/submissions/detail?uuid=92cb09ba-d7a4-4c1f-a6cb-56e1c0464357

I also noticed that it would take me to login page first for sometime before it redirects me to the submission details page.

MightyAx · 2020-10-07T15:43:06Z

Thanks @aaclan-ebi:
I see these errors in the Javascript console that I imagine are the culprits, I'm investigating

[Error] ERROR – TypeError: undefined is not an object (evaluating 'e._links')
TypeError: undefined is not an object (evaluating 'e._links')(anonymous function)

[Error] ERROR – TypeError: null is not an object (evaluating 'this.submissionEnvelopeId.length')
TypeError: null is not an object (evaluating 'this.submissionEnvelopeId.length')
	dr (main.4cfd5975e411d38be33b.js:1:3015587)
	handleError (main.4cfd5975e411d38be33b.js:1:3015758)
	next (main.4cfd5975e411d38be33b.js:1:3107854)

…half a second.

MightyAx · 2020-10-07T18:35:12Z

However, I still found a submission which is not loading:
https://dev.contribute.data.humancellatlas.org/submissions/detail?uuid=92cb09ba-d7a4-4c1f-a6cb-56e1c0464357

Can confirm fixed on dev

aaclan-ebi · 2020-10-08T10:37:12Z

However, I still found a submission which is not loading:
https://dev.contribute.data.humancellatlas.org/submissions/detail?uuid=92cb09ba-d7a4-4c1f-a6cb-56e1c0464357

Can confirm fixed on dev

Yes, it's loading now! thanks for fixing it!

I also noticed that it would take me to login page first for sometime before it redirects me to the submission details page.

Did you get a chance to replicate this?

…st wait for real response from aai, in the case of a hard refresh killing the cachedUser. Comments to clarify use of userSubject subscriptions

…ct param on login page)

aaclan-ebi

Thanks for spending so much effort on cleaning up our UI code!

I've reviewed the changes. It's a big change, I tried to navigate around in dev, it seems to work the same as before. If we find any issues, let's just fix it as we go. Basic submission flow seems to work fine. Let's merge this soon :)

Linting Fixups

7b059d1

MightyAx requested a review from a team September 25, 2020 11:05

MightyAx self-assigned this Sep 25, 2020

MightyAx marked this pull request as ready for review September 25, 2020 11:08

aaclan-ebi approved these changes Sep 25, 2020

View reviewed changes

Remove RxJS compact and reformat Observable maps to pipelines.

369bfc1

MightyAx requested review from aaclan-ebi and a team September 25, 2020 16:10

MightyAx commented Sep 25, 2020

View reviewed changes

client/src/app/project-registration/contact-field-group/contact-field-group.component.spec.ts Outdated Show resolved Hide resolved

MightyAx added 6 commits September 28, 2020 11:00

RxJS interval waits for one interval before it starts to emmit, switc…

f2005b5

…hing to use timer instead.

StartWith is not Deprecated ReactiveX/rxjs#4772

0f0a24b

Move maps for typing into services

fe1b173

Use SwitchMap if we can throw away the sub-process when a new event i…

3775be0

…s emitted by the source. Useful for search controls.

Use distinctUntilChanged to not throw away SwitchMaps unless input va…

36319d9

…lue has changed.

Lint Fixups

c845866

rolando-ebi approved these changes Sep 29, 2020

View reviewed changes

client/src/app/my-projects/my-projects.component.ts Outdated Show resolved Hide resolved

client/src/app/aai/aai.service.ts Outdated Show resolved Hide resolved

client/src/app/shared/services/ontology.service.ts Show resolved Hide resolved

MightyAx added 4 commits September 29, 2020 17:35

Remove fork join in favour of combine latest.

fc84180

Review fixup: pipe functions on newline.

841602f

simpler routerlink

1313dda

Review fixup: correct type of isLoggedIn$

dfaccbb

aaclan-ebi approved these changes Sep 30, 2020

View reviewed changes

rolando-ebi reviewed Oct 1, 2020

View reviewed changes

client/src/app/template-questionnaire/template-generator.service.ts Outdated Show resolved Hide resolved

MightyAx added 7 commits October 1, 2020 15:08

Add comment for deprecation false-positive: ReactiveX/rxjs#4772

3f05821

Fix Project ID Validator

6f1ef0e

Only regenerate Project ID if the first corresponding contributor's n…

2272106

…ame changes. Rather than regenerating everytime anything about the first corresponding contributor changes.

Fixup template generator RxJS functionality change.

9c26419

Fix infinite loop caused by login bug by filtering calls to Behaviour…

b2445c7

…Subject.next

Fixup: Remove user on error.

2208a14

Unit Test Fixes

895dacb

ebi-ait deleted a comment from aaclan-ebi Oct 6, 2020

MightyAx requested a review from a team October 6, 2020 16:23

MightyAx commented Oct 7, 2020

View reviewed changes

client/src/app/shared/guards/user-is-logged-in.guard.ts Outdated Show resolved Hide resolved

MightyAx commented Oct 7, 2020

View reviewed changes

rolando-ebi reviewed Oct 7, 2020

View reviewed changes

client/src/app/project-registration/contact-field-group/contact-field-group.component.ts Outdated Show resolved Hide resolved

rolando-ebi reviewed Oct 7, 2020

View reviewed changes

client/src/app/project-registration/project-id/project-id.component.ts Show resolved Hide resolved

Add null object check in case core does not return submission within …

829000a

…half a second.

MightyAx added 2 commits October 9, 2020 18:02

Fix login flicker by reintroducing observables for components that mu…

a456841

…st wait for real response from aai, in the case of a hard refresh killing the cachedUser. Comments to clarify use of userSubject subscriptions

Allow caught error pages to include url parameters, (including redire…

942f32d

…ct param on login page)

MightyAx requested a review from aaclan-ebi October 12, 2020 09:22

aaclan-ebi approved these changes Oct 13, 2020

View reviewed changes

MightyAx merged commit 0e831ba into master Oct 13, 2020

MightyAx deleted the cleanup/lint-and-tests branch October 13, 2020 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linting Fixups #53

Linting Fixups #53

MightyAx commented Sep 25, 2020 •

edited

Loading

aaclan-ebi left a comment

MightyAx commented Sep 25, 2020 •

edited

Loading

rolando-ebi left a comment

aaclan-ebi left a comment

MightyAx Oct 7, 2020 •

edited

Loading

aaclan-ebi commented Oct 7, 2020

MightyAx commented Oct 7, 2020

aaclan-ebi commented Oct 7, 2020 •

edited

Loading

MightyAx commented Oct 7, 2020

MightyAx commented Oct 7, 2020

aaclan-ebi commented Oct 8, 2020

aaclan-ebi left a comment •

edited

Loading

Linting Fixups #53

Linting Fixups #53

Conversation

MightyAx commented Sep 25, 2020 • edited Loading

aaclan-ebi left a comment

Choose a reason for hiding this comment

MightyAx commented Sep 25, 2020 • edited Loading

rolando-ebi left a comment

Choose a reason for hiding this comment

aaclan-ebi left a comment

Choose a reason for hiding this comment

MightyAx Oct 7, 2020 • edited Loading

Choose a reason for hiding this comment

aaclan-ebi commented Oct 7, 2020

MightyAx commented Oct 7, 2020

aaclan-ebi commented Oct 7, 2020 • edited Loading

MightyAx commented Oct 7, 2020

MightyAx commented Oct 7, 2020

aaclan-ebi commented Oct 8, 2020

aaclan-ebi left a comment • edited Loading

Choose a reason for hiding this comment

MightyAx commented Sep 25, 2020 •

edited

Loading

MightyAx commented Sep 25, 2020 •

edited

Loading

MightyAx Oct 7, 2020 •

edited

Loading

aaclan-ebi commented Oct 7, 2020 •

edited

Loading

aaclan-ebi left a comment •

edited

Loading