Allowing to parse hex strings into the Integer type #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarnard
requested changes
Jun 6, 2019
|
Released in 0.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number representation in the NetBSD proplist implementation
proplibis a little bit different from the Apple one, see the PROP_NUMBER(3) page for details.Implementing all this stuff would vastly decrease the Integer'
FromStrimplementation performance, so I'm not sure yet if it even should be implemented fully (ex. if representation starts with a0xthen it is an unsigned number), so as a draft, I've added the ability to parse the hexademical strings.Another option would be to feature-gate it (like
#[cfg(target_os = "netbsd")]), but I'm not quite sure about it too — someone might want to parse the NetBSD files in the different OS, right?