-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better 3d model path handling and add support for named variables for… #177
base: master
Are you sure you want to change the base?
Conversation
… path instead of using 4 text boxes to define path alternatives, now we have a multi-line text area which user can add any number of paths, each path in one line, and also user can define a named path with the format NAMED_PATH@PATH_VALUE that results better handling of KiCad style path variables.
The scenario that user updates this mod from previous versions is not considered yet, I should take care of importing alternate paths 1 to 4 to the new path model if their values are present in preferences. |
It's strange. Thank you for letting me know. I will look at this in the future days, but if you are in a hurry, you can do the following for now. Make sure you can see the textbox in the "Addon Manager" preferences, like below: If you can see it, I think it might be an issue in layout or component position after adding the text area. |
I've worked around this by setting the values directly in
As you can see, I'd like to use recursive variable expansion the way KiCad does; for this I moved the "extra local ${ENV} 3D path" block up before line 4415 and as a separate if block (not chained with elseif). That works for my specific case, but really this whole section should be rewritten properly to deal with any number of (recursive) variables in any order. |
I was about to suggest a similar change, but maybe this enhancement should be bundled in this PR. I modified StepUp to read KiCad's |
… path
instead of using 4 text boxes to define path alternatives, now we have a multi-line text area which user can add any number of paths, each path in one line, and also user can define a named path with the format NAMED_PATH@PATH_VALUE that results better handling of KiCad style path variables.