Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for translate WB #142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Kuzma30
Copy link
Contributor

@Kuzma30 Kuzma30 commented Jul 23, 2022

No description provided.

@Kuzma30
Copy link
Contributor Author

Kuzma30 commented Jul 25, 2022

ping @easyw

@Kuzma30
Copy link
Contributor Author

Kuzma30 commented Aug 2, 2022

Anybody home and read this? Can I continue patch for localization or this is not interesting for author?

@easyw
Copy link
Owner

easyw commented Aug 12, 2022

hi @Kuzma30
sorry for being late in replying you...
yes this is a interesting feature...
I have limitated access to web atm... I'm going to follow this PR amd its evolution
you can ping me or PM at kicad.info forum ... I check it more frequently

@Kuzma30
Copy link
Contributor Author

Kuzma30 commented Aug 24, 2022

hi @Kuzma30
sorry for being late in replying you...
yes this is a interesting feature...
I have limitated access to web atm... I'm going to follow this PR amd its evolution
you can ping me or PM at kicad.info forum ... I check it more frequently

You can merge this PR in current state.

@easyw
Copy link
Owner

easyw commented Aug 31, 2022

@Kuzma30
I'm not used to add translations to a project...
Does the '.ts' file need to be manually edited, pointing to the exact line number, or it is automatically generated?
I see there is some wip also here...
easyw/Manipulator#11
Are these two PRs based on the same method?

@Kuzma30
Copy link
Contributor Author

Kuzma30 commented Aug 31, 2022

Ts file generated by Qt tools program.
This link may be useful https://wiki.freecadweb.org/Translating_an_external_workbench

@Kuzma30
Copy link
Contributor Author

Kuzma30 commented Dec 13, 2022

Hi @easyw.
What is a reason do not merge translation support for your WB?)

@easyw
Copy link
Owner

easyw commented Jan 18, 2023

@Kuzma30
sorry for delaying in reviewing this PR... I don't check often GH messages.

My issue with this PR is that I'm not familiar with the process in translation wbs.

If I understand it correctly, this PR is just a first step to start the translation process.
Do you have a repository with a more advanced translation status of the wb?
Then I would be more confident in merging it.

Thanks for working on this aspect, that I would like to be integrated in StepUp.

@kaktusus
Copy link
Contributor

@easyw
Kuzma30 participated in improving the quality of FreeCAD's GUI translations.
Several of his PRs with translation improvements have been merged in the past.
He lives in Ukraine. Since Ukraine has been invaded he has not been able to be contacted.

From your conversation, it seems that the code was prepared by him and has been waiting to be merged for a year.
I think there is nothing to wait further. :Wink:

@kaktusus
Copy link
Contributor

kaktusus commented Aug 26, 2023

@easyw
I have prepared some links for you. If you still have some doubts or feel deficient in knowledge these posts will certainly be helpful. 😉

@luzpaz
Copy link
Contributor

luzpaz commented Nov 2, 2023

any progress here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants