Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation in Easystack examples #855

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Jan 20, 2023

The examples with the additional options don't work, e.g. the first one from https://docs.easybuild.io/en/latest/Easystack-files.html#combining-command-line-options-with-options-in-an-easystack-file results in:

ERROR: Failed to parse easystack file: expected a dictionary with one key (the EasyConfig name), instead found keys: PyTorch-1.12.0-foss-2022a-CUDA-11.7.0.eb, options, see https://docs.easybuild.io/en/latest/Easystack-files.html for documentation.

Looking at an example from the tests at https://github.com/easybuilders/easybuild-framework/blob/develop/test/framework/easystacks/test_easystack_easyconfigs_opts.yaml, the additional options need more indentation, and the following does indeed work:

easyconfigs:
  - PyTorch-1.12.0-foss-2022a-CUDA-11.7.0.eb:
      options:
        from-pr: 15924
        debug: True
  - OpenFOAM-v2206-foss-2022a.eb:

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 0215f2c into easybuilders:develop Jan 20, 2023
@bedroge bedroge deleted the fix_easystack_indentation branch January 20, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants