Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for SOFTROOT keys in environ #73

Merged
merged 2 commits into from
Aug 10, 2012

Conversation

nudded
Copy link

@nudded nudded commented Aug 10, 2012

No description provided.

if bad_keys:
log.error("You have some easybuild modules loaded: %s are set in your environment" % bad_keys)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line.

itkovian added a commit that referenced this pull request Aug 10, 2012
add check for SOFTROOT keys in environ
@itkovian itkovian merged commit 6a50b80 into easybuilders:develop Aug 10, 2012
@boegel
Copy link
Member

boegel commented Aug 10, 2012

This shouldn't go into the next EasyBuild release, as this kills the workaround we have for the modulecmd crashes, i.e. manually loading some modules (e.g. the toolkit) before running EasyBuild.

These commits need to be removed.

nudded pushed a commit to nudded/easybuild that referenced this pull request Aug 13, 2012
…ed-modules"

This reverts commit 6a50b80, reversing
changes made to da296a2.
boegel added a commit that referenced this pull request Aug 13, 2012
Revert "Merge pull request #73 from nudded/346-check-loaded-modules"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants