Honor sanity_check_commands & sanity_check_paths from extensions
#5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
extension-sanity-check-commands
branch
from
8743828 to
5943e1d
Compare
Open
3 tasks
Flamefire
force-pushed
the
extension-sanity-check-commands
branch
from
5943e1d to
34718cd
Compare
When no changes are to be made we can exit early which especially avoids the `module list` command whose output is unused in this case causing unecessary overhead.
Many tests modify the environment in some steps and need to restore it afterwards. To avoid missing this the contextmanager does that automatically.
This now calls the inherited `EasyBlock.sanity_check_step` that handles the `sanity_check_commands` & `sanity_check_paths` for extensions too.
It is redundant as `self.is_extension` provides that information already.
Many tests modify the environment in some steps and need to restore it afterwards. To avoid missing this the contextmanager does that automatically.
Flamefire
force-pushed
the
extension-sanity-check-commands
branch
from
e1fd987 to
4b556af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently those are silently ignored leading to success where it should fail.
The only official easyconfig affected by this so far is
MDAnalysis-2.4.2-foss-2021a.ebbut I ran into this while creating an easyconfigIncludes