avoid suggesting that toolchainopts are supported for SYSTEM compiler, since they're not

[ocaisa]

Fixes #4584

[ocaisa]

Whether we should support toolchainopts is up for debate, but this PR reflects the current status

[ocaisa]

This will require a companion PR to SYSTEM easyconfigs that try to set toolchainopts as this will no longer be allowed

[branfosj]

This will require a companion PR to SYSTEM easyconfigs that try to set toolchainopts as this will no longer be allowed

See easybuilders/easybuild-easyconfigs#21035 - though that targets the 5.0.x branch.

[ocaisa]

@branfosj I've retargeted this to 5.0 as well

[Micket]

Would it not be more appropriate to do this to SystemCompiler instead of SystemToolchain?
Does it need to set COMPILER_UNIQUE_OPTION_MAP to none as well, given that it is none from the start?

I really don't think there is any reason not to support these though, everything in COMPILER_SHARED_OPTS is expected to be shared among all the compilers, so we certainly would assume the system compiler to support them as well.

[ocaisa]

This is not trivial to do, as for the system compiler there are specific things happening

easybuild-framework/easybuild/tools/toolchain/toolchain.py

Lines 829 to 856 in e913a78

	if self.is_system_toolchain():
	# define minimal build environment when using system toolchain;
	# this is mostly done to try controlling which compiler commands are being used,
	# cfr. https://github.com/easybuilders/easybuild-framework/issues/3398
	self.set_minimal_build_env()
	else:
	trace_msg("defining build environment for %s/%s toolchain" % (self.name, self.version))
	if not self.dry_run:
	self._verify_toolchain()
	# Generate the variables to be set
	self.set_variables()
	# set the variables
	# onlymod can be comma-separated string of variables not to be set
	if onlymod is True:
	self.log.debug("prepare: do not set additional variables onlymod=%s", onlymod)
	self.generate_vars()
	else:
	self.log.debug("prepare: set additional variables onlymod=%s", onlymod)
	# add LDFLAGS and CPPFLAGS from dependencies to self.vars
	self._add_dependency_variables()
	self.generate_vars()
	self._setenv_variables(onlymod, verbose=not silent)

[branfosj]

@branfosj I've retargeted this to 5.0 as well

Once easybuilders/easybuild-easyconfigs#21035 is approved and merged then I am happy to proceed with this. It makes the processing of easyconfigs behave how the SYSTEM toolchain works currently - avoiding unexepected behaviour. We can always revisit making the SYSTEM toolchain behave more similarly to other toolchains in the future.

[ocaisa]

@Micket I did give this a try this morning but it is complicated, I could not successfully extract the CFLAGS and CXXFLAGS. I've moved the changes to the parent class and left a comment there about what you would need to do if you wanted to change things

[ocaisa]

There is a failing test that I'm amazed worked in the first place:

easybuild-framework/test/framework/toy_build.py

Lines 2739 to 2745 in 1148625

	# test use of rpath toolchain option
	test_ecs = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'easyconfigs', 'test_ecs')
	toy_ec_txt = read_file(os.path.join(test_ecs, 't', 'toy', 'toy-0.0.eb'))
	toy_ec_txt += "\ntoolchainopts = {'rpath': False}\n"
	toy_ec = os.path.join(self.test_prefix, 'toy.eb')
	write_file(toy_ec, toy_ec_txt)
	self.test_toy_build(ec_file=toy_ec, extra_args=['--rpath'], raise_error=True)

[ocaisa]

@branfosj Should be good to go now

[boegel]

lgtm

[boegel]

lgtm