fix getting all available output for interactive commands + fix logging end of output when no match was found in run_shell_cmd
#4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Q&A shell command run via run_shell_cmd
branfosj
reviewed
Apr 6, 2024
easybuild/tools/run.py
Outdated
|
|
||
| # note: we assume that there won't be any questions in stderr output | ||
| if split_stderr: | ||
| stderr += proc.stderr.read1(read_size) or b'' | ||
| more_stderr = True | ||
| while more_stdout: |
There was a problem hiding this comment.
Suggested change
| while more_stdout: | |
| while more_stderr: |
boegel
changed the title
run_shell_cmdrun_shell_cmd
boegel
commented
Apr 6, 2024
easybuild/tools/run.py
Outdated
|
|
||
| if qa_patterns: | ||
| if _answer_question(stdout, proc, qa_patterns, qa_wait_patterns): | ||
| time_no_match = 0 | ||
| else: | ||
| _log.debug(f"No match found in question/wait patterns at end of stdout: {stdout[:1000]}") | ||
| _log.debug(f"No match found in question/wait patterns at end of stdout: {stdout[:-1000]}") |
There was a problem hiding this comment.
This needs more work, don't merge yet please...
boegel
force-pushed
the
run_shell_cmd_qa_buffering
branch
from
2c77d7d to
0e15657
Compare
branfosj
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix, required for installing Maple (cfr. easybuilders/easybuild-easyblocks#3286)