Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from ls to bash in tests that are expecting this to be a binary #4492

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Mar 31, 2024

I'm running in a Rocky 8.9 container (that is based off the one from https://github.com/easybuilders/easybuild-containers) and I hit two test failures that are caused by ls not being as expected, which causes the two tests I am changing to fail.

In the container where I see the failure:

$ file /bin/ls
/bin/ls: a /usr/bin/coreutils --coreutils-prog-shebang=ls script, ASCII text executable

$ file /bin/bash
/bin/bash: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=e4abb3b0b8951a4f746530ae2e9b85559d5fb98f, stripped

On Ubuntu:

$ file /bin/ls
/bin/ls: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=9a7a491cbe4f1b92cb270406d6642d545b7d1259, for GNU/Linux 3.2.0, stripped

$ file /bin/bash
/bin/bash: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=070009c7b6202e25d64caf24bb49c6cede3a794c, for GNU/Linux 3.2.0, stripped

@branfosj branfosj added this to the 5.0 milestone Mar 31, 2024
@branfosj branfosj changed the title switch from to bash in tests switch from ls to bash in tests that are expecting this to be a binary Mar 31, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also works fine on macOS

$ file /bin/bash
/bin/bash: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/bin/bash (for architecture x86_64):	Mach-O 64-bit executable x86_64
/bin/bash (for architecture arm64e):	Mach-O 64-bit executable arm64e

@boegel boegel merged commit 1df8073 into easybuilders:5.0.x Apr 2, 2024
35 checks passed
@branfosj branfosj deleted the bash branch April 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants