Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change run_shell_cmd to store command output in temporary file(s) by default + pass RunShellCmdResult instance to RunShellCmdError #4356

Merged
merged 10 commits into from
Nov 8, 2023
Merged

change run_shell_cmd to store command output in temporary file(s) by default + pass RunShellCmdResult instance to RunShellCmdError #4356

merged 10 commits into from
Nov 8, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 21, 2023

WIP because i) tests still fail, ii) it sits on top of #4351 which should get merged first

@boegel boegel added this to the 5.0 milestone Oct 21, 2023
@boegel boegel requested a review from lexming October 21, 2023 08:58
@boegel boegel mentioned this pull request Oct 21, 2023
Merged
@boegel boegel changed the base branch from develop to 5.0.x October 23, 2023 07:36
@boegel boegel force-pushed the run_shell_cmd_out_files branch from 09d3dbc to 05374ad Compare October 23, 2023 07:37
@easybuilders easybuilders deleted a comment from boegelbot Oct 23, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 6, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 6, 2023
@boegel boegel changed the title change run_shell_cmd to always store command output in temporary file(s) + pass RunShellCmdResult instance to RunShellCmdError change run_shell_cmd to store command output in temporary file(s) by default + pass RunShellCmdResult instance to RunShellCmdError Nov 6, 2023
@boegel boegel marked this pull request as ready for review November 7, 2023 20:34
lexming
lexming reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passing the output and error file pointers to RunShellCmdError from the outside will avoid the duplicate logs. I have a minor nitpick suggestion :)

easybuild/tools/run.py Outdated Show resolved Hide resolved
@lexming lexming enabled auto-merge November 8, 2023 13:06
lexming
lexming approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming merged commit 6b09872 into easybuilders:5.0.x Nov 8, 2023
34 checks passed
@boegel boegel deleted the run_shell_cmd_out_files branch November 8, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
bug fix change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @lexming