Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset tempfile.tempdir to None to avoid that tmpdir path gets progressively deeper with each easystack item #4350

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 27, 2023

fixes #4291

@boegel boegel added bug fix easystack Issues and PRs related to easystack files labels Sep 27, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Sep 27, 2023
@boegel boegel requested a review from bedroge September 27, 2023 06:50
@boegel boegel changed the title reset tempdir to avoid that tmpdir path gets progressively deeper with each easystack item reset tempfile.tempdir to None to avoid that tmpdir path gets progressively deeper with each easystack item Sep 27, 2023
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/framework/easystack.py Outdated Show resolved Hide resolved
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in test needs fixing

…mine length of tmpdir path in tempfile

Co-authored-by: ocaisa <alan.ocais@cecam.org>
@boegel boegel removed the request for review from bedroge September 27, 2023 13:42
@ocaisa ocaisa enabled auto-merge September 27, 2023 13:43
@ocaisa ocaisa merged commit dfe3b3f into easybuilders:develop Sep 27, 2023
@boegel boegel deleted the easystack_tmpdir_fix branch September 27, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix easystack Issues and PRs related to easystack files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested temporary directories for easystack items
2 participants