Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace imp.load_source by leveraging importlib.util.module_from_spec when using Python 3 #4280

Merged
merged 2 commits into from
Jun 12, 2023
Merged

replace imp.load_source by leveraging importlib.util.module_from_spec when using Python 3 #4280

merged 2 commits into from
Jun 12, 2023

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jun 11, 2023 •
edited
Loading

bartoldeman
bartoldeman approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit cef915b into easybuilders:develop Jun 12, 2023
@branfosj branfosj deleted the imp branch June 12, 2023 12:14
@boegel boegel changed the title replace imp.load_source replace imp.load_source by leveraging importlib.util.module_from_spec when using Python 3 Jun 20, 2023
@boegel boegel added this to the next release (4.7.3?) milestone Jun 20, 2023
@boegel boegel added the change label Jun 20, 2023
@boegel boegel mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

stop relying on imp (will no longer be available in Python 3.12)
3 participants
@branfosj @bartoldeman @boegel