-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use version suffixes in PR title instead of Python versions when using --new-pr #4253
Conversation
@Micket Can you clarify why this is marked as draft? |
I never got around to test any of the code at all. Might work, 100% untested |
I think this works fine
when testing with a few random easyconfigs |
So the test for this whole new PR function is at easybuild-framework/test/framework/options.py Line 4177 in f378bac
I do think we should pull this code out into a separate function and test it separately. Then, in an outside the scope of this PR, we'd be able to hook it into the review PR code to have it suggest a PR title should be. |
I'm not sure how to best set up tests for this. It's isolated to just the |
See Micket#2 |
Also, if there are any other unusual software names / versions / versionsuffixes we should test then let me know and I'll add some more. |
add tests for det_pr_title
Has bothered me for a while now. the w/ Python 3.x.y in the titles are pretty much useless these days, and instead important information like if a CUDA build is left out.
This puts all the suffixes in there instead.