Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce number of CI jobs by testing for Lua and Tcl module syntax in a single CI job #4192

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jan 20, 2023

We run into rate limits installing the dependencies. We can reduce the number of CI jobs to almost half by running the tests in a loop for each supported module syntax.

See e.g. https://github.com/easybuilders/easybuild-framework/actions/runs/3965853121/jobs/6796017484

@boegel
Copy link
Member

boegel commented Jan 20, 2023

Each test suite runs takes about 15min, if we run the test suite twice in a CI jobs, don't we risk effectively doubling the waiting time for testsuite runs in all configurations to complete?

@Flamefire
Copy link
Contributor Author

Each test suite runs takes about 15min, if we run the test suite twice in a CI jobs, don't we risk effectively doubling the waiting time for testsuite runs in all configurations to complete?

Yes, IF formerly the jobs ran in parallel. But IIRC the free GHA plan has a limit on the number of parallel jobs which I think we still run into: I mean look at the number of checks the are run.

So in practice I'd say it even reduces the waiting time because the common stuff (installing dependencies) is only done once instead of twice. Furthermore jobs failing due to hitting rate limits IMO increase the time by much more or may erroneously completely block a PR

@boegel boegel changed the title reduce number of CI jobs reduce number of CI jobs by testing for Lua and Tcl module syntax in a single CI job Feb 1, 2023
@Flamefire Flamefire force-pushed the gha_ci_reduce branch 3 times, most recently from 7df4aa7 to 26c8d20 Compare May 11, 2023 16:53
@Flamefire
Copy link
Contributor Author

Looks good so far (longest run is 37min) but required checks need updating for/after this.

@easybuilders easybuilders deleted a comment from boegelbot May 23, 2023
@boegel boegel modified the milestones: 4.x, release after 4.7.2 May 23, 2023
@boegel boegel modified the milestones: 4.7.3, release after 4.7.3 Jul 5, 2023
We run into rate limits installing the dependencies.
We can reduce the number of CI jobs to almost half by running the tests
in a loop for each supported module syntax.
@boegel boegel merged commit d450a80 into easybuilders:develop Sep 27, 2023
@Flamefire Flamefire deleted the gha_ci_reduce branch September 28, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants