add support for postinstallmsgs #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
boegel
requested changes
Dec 21, 2022
easybuild/framework/easyblock.py
Outdated
| @@ -2952,6 +2952,12 @@ def apply_post_install_patches(self, patches=None): | |||
| # To allow postinstallpatches for Bundle, and derived, easyblocks we directly call EasyBlock.patch_step | |||
| EasyBlock.patch_step(self, beginpath=self.installdir, patches=patches) | |||
|
|
|||
| def log_post_install_messages(self): | |||
There was a problem hiding this comment.
log_ is a bit of a misnomer, may use print_post_install_messages?
Please add a docstring to this new function as well.
easybuild/framework/easyblock.py
Outdated
| @@ -2952,6 +2952,12 @@ def apply_post_install_patches(self, patches=None): | |||
| # To allow postinstallpatches for Bundle, and derived, easyblocks we directly call EasyBlock.patch_step | |||
| EasyBlock.patch_step(self, beginpath=self.installdir, patches=patches) | |||
|
|
|||
| def log_post_install_messages(self): | |||
| messages = self.cfg["postinstallmsgs"] | |||
| if messages: | |||
There was a problem hiding this comment.
perhaps better (also log messages being printed)
msgs = self.cfg['postinstallmsgs'] or []
for msg in msgs:
print_msg(msg, log=self.log)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)fixes #542