avoid uploading test reports when no easyconfigs are (re)built #3957
Conversation
| @@ -474,6 +474,8 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None): | |||
| ordered_ecs = easyconfigs | |||
| elif pr_options: | |||
| ordered_ecs = None | |||
| elif options.upload_test_report: | |||
| raise EasyBuildError("No easyconfigs left to be built (use --rebuild?)") | |||
There was a problem hiding this comment.
Hmm, I wonder if we should somehow allow uploading the test report anyway (but --force won't work for this...).
Even if all easyconfigs are already installed, there are exceptional use cases where it may be useful to upload a test report (to communicate system info and EasyBuild configuration, for example)
There was a problem hiding this comment.
yeah, I hadn't considered using it to share system info/configuration, so an override would definitely be useful. Maybe something like --upload-test-report=force?
There was a problem hiding this comment.
That could work, yes...
That would involve making --upload-test-report a store_or_None option, so you can allow using it both with and without passing a value; see also --inject-checksums or --force-download for example.
Are you up for looking into this yourself?
There was a problem hiding this comment.
when I actually have time again, sure :)
(created using
eb --new-pr)