Fix import of multiple easyblocks #3791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flamefire: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-framework/actions/runs/1082638830 bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
Honor priority: PR EBs before standard EBs and add test and fix for it as suggested by @migueldiascosta
Use EB_GITHUB_TEST_ACCOUNT env variable to specify your personal account to use for tests. Useful to avoid rate limits
Flamefire
force-pushed
the
import-multiple-easyblocks
branch
from
bf87587 to
adb6a0b
Compare
|
@Flamefire: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-framework/actions/runs/2998365230 bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
Flamefire
force-pushed
the
import-multiple-easyblocks
branch
from
adb6a0b to
1ba3079
Compare
|
@Flamefire: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-framework/actions/runs/3000863860 bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
|
@boegel Can we simply drop support for Python 3.5? It is EOL and unsupported by many tools. I also can't reproduce the CI failure locally but getting a Python 3.5 on a recent system is already hard as it requires OpenSSL 1.0 which is hard to come by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3780 as fixing the issue with single PRs is much easier then messing with all this import stuff
Additionally fixes including easyblocks from multiple PRs and the manipulations of sys.path/modules/...