Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate EasyBuild bootstrap script #3742

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Conversation

branfosj
Copy link
Member

@@ -854,6 +854,8 @@ def main():
self_txt = open(__file__).read()
if IS_PY3:
self_txt = self_txt.encode('utf-8')
info("DEPRECATED: Use of the EasyBuild boostrap script is deprecated and may not work.")
info("Recommended install methods: https://docs.easybuild.io/en/latest/Installation.html\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take this one step further, and abort the bootstrap unless an environment variable like $EASYBUILD_BOOTSTRAP_DEPRECATED is defined, to actively discourage still using it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel boegel changed the title point people to other install methods than the boostrap deprecate EasyBuild bootstrap script Jun 18, 2021
@boegel boegel added the change label Jun 18, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jun 18, 2021
boegel and others added 3 commits June 18, 2021 10:58
… about not knowing this configuration option
require that $EASYBUILD_BOOTSTRAP_DEPRECATED is defined to run EasyBuild bootstrap script
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants