-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate EasyBuild bootstrap script #3742
Conversation
easybuild/scripts/bootstrap_eb.py
Outdated
@@ -854,6 +854,8 @@ def main(): | |||
self_txt = open(__file__).read() | |||
if IS_PY3: | |||
self_txt = self_txt.encode('utf-8') | |||
info("DEPRECATED: Use of the EasyBuild boostrap script is deprecated and may not work.") | |||
info("Recommended install methods: https://docs.easybuild.io/en/latest/Installation.html\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would take this one step further, and abort the bootstrap unless an environment variable like $EASYBUILD_BOOTSTRAP_DEPRECATED
is defined, to actively discourage still using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see branfosj#2
…ild bootstrap script
… about not knowing this configuration option
require that $EASYBUILD_BOOTSTRAP_DEPRECATED is defined to run EasyBuild bootstrap script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
related to easybuilders/easybuild#718